Review Request: Properly strip HTML from assistants' title and action descriptions when converting them to KAction/QMenu.

[Christoph Feck]

> On Jan. 5, 2013, 9:04 p.m., Commit Hook wrote:
> > This review has been submitted with commit b28f0aecc6347332d48f49f3b6271ee4a5b9c697 by Ivan Shapovalov to branch master.

This causes build failure. I think it cannot work, because kdevplatforminterfaces cannot link to kdevplatformutil, because that already links to kdevplatforminterfaces. I guess that static function has to stay, but if you find another solution, no problem :)

CMakeFiles/kdevplatforminterfaces.dir/iassistant.o: In function `KDevelop::IAssistantAction::toKAction() const':
/local/git/extragear/kdevelop/kdevplatform/interfaces/iassistant.cpp:33: undefined reference to `KDevelop::removeHtmlFromString(QString const&)'
collect2: error: ld returned 1 exit status
make[2]: *** [lib/libkdevplatforminterfaces.so.7.0.0] Error 1
make[2]: Target `interfaces/CMakeFiles/kdevplatforminterfaces.dir/build' not remade because of errors.
make[1]: *** [interfaces/CMakeFiles/kdevplatforminterfaces.dir/all] Error 2
make[1]: Target `all' not remade because of errors.
make: *** [all] Error 2
make: Target `default_target' not remade because of errors.
-- Failed: extragear/kdevelop/kdevplatform


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108146/#review24777
-----------------------------------------------------------


On Jan. 4, 2013, 5:48 p.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108146/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2013, 5:48 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Fix HTML -> plaintext conversion when converting assistants to KAction/QMenu. This fixes at least one visible case - invoking context menu on a problem with missing declaration assistant.
> 
> 
> Diffs
> -----
> 
>   interfaces/iassistant.cpp 8d433a3 
>   plugins/problemreporter/problemreporterplugin.cpp 27e41ee 
>   util/formattinghelpers.h d82d421 
>   util/formattinghelpers.cpp b646068 
> 
> Diff: http://git.reviewboard.kde.org/r/108146/diff/
> 
> 
> Testing
> -------
> 
> Apparently works.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130106/5ffde180/attachment.html>