<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108146/">http://git.reviewboard.kde.org/r/108146/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 5th, 2013, 9:04 p.m., <b>Commit Hook</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit b28f0aecc6347332d48f49f3b6271ee4a5b9c697 by Ivan Shapovalov to branch master.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This causes build failure. I think it cannot work, because kdevplatforminterfaces cannot link to kdevplatformutil, because that already links to kdevplatforminterfaces. I guess that static function has to stay, but if you find another solution, no problem :)
CMakeFiles/kdevplatforminterfaces.dir/iassistant.o: In function `KDevelop::IAssistantAction::toKAction() const':
/local/git/extragear/kdevelop/kdevplatform/interfaces/iassistant.cpp:33: undefined reference to `KDevelop::removeHtmlFromString(QString const&)'
collect2: error: ld returned 1 exit status
make[2]: *** [lib/libkdevplatforminterfaces.so.7.0.0] Error 1
make[2]: Target `interfaces/CMakeFiles/kdevplatforminterfaces.dir/build' not remade because of errors.
make[1]: *** [interfaces/CMakeFiles/kdevplatforminterfaces.dir/all] Error 2
make[1]: Target `all' not remade because of errors.
make: *** [all] Error 2
make: Target `default_target' not remade because of errors.
-- Failed: extragear/kdevelop/kdevplatform
</pre>
<br />
<p>- Christoph</p>
<br />
<p>On January 4th, 2013, 5:48 p.m., Ivan Shapovalov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Ivan Shapovalov.</div>
<p style="color: grey;"><i>Updated Jan. 4, 2013, 5:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix HTML -> plaintext conversion when converting assistants to KAction/QMenu. This fixes at least one visible case - invoking context menu on a problem with missing declaration assistant.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Apparently works.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>interfaces/iassistant.cpp <span style="color: grey">(8d433a3)</span></li>
<li>plugins/problemreporter/problemreporterplugin.cpp <span style="color: grey">(27e41ee)</span></li>
<li>util/formattinghelpers.h <span style="color: grey">(d82d421)</span></li>
<li>util/formattinghelpers.cpp <span style="color: grey">(b646068)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108146/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>