Review Request: TestView: show ProjectModel folder

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108209/#review24802
-----------------------------------------------------------

Ship it!


Very cool, thanks for working on that. I spotted two minor things.


plugins/testview/testview.cpp
<http://git.reviewboard.kde.org/r/108209/#comment19051>

    maybe use a switch instead? or at least add a "reason" for the assertion, i.e.: kWarning() << "unhandled item type encountered:" << item->data(ItemTypeRole);



plugins/testview/testview.cpp
<http://git.reviewboard.kde.org/r/108209/#comment19052>

    again, switch + kWarning in Q_ASSERT case


- Milian Wolff


On Jan. 5, 2013, 8:31 p.m., Niko Sams wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108209/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2013, 8:31 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Instead of the flat view this patch adds tests into folders like they are in the ProjectModel.
> 
> 
> Diffs
> -----
> 
>   interfaces/itestsuite.h bc974fc 
>   plugins/testview/testview.h dfbbbfd 
>   plugins/testview/testview.cpp d6be5f4 
>   shell/tests/testcontrollertest.cpp 720e53d 
> 
> Diff: http://git.reviewboard.kde.org/r/108209/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/108209/s/983/
> 
> 
> Thanks,
> 
> Niko Sams
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130106/c1af55c1/attachment.html>