Review Request: ProjectProxyModel: show real filtered item count

Ivan Shapovalov intelfx100 at gmail.com
Sat Jan 5 20:59:25 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108210/
-----------------------------------------------------------

Review request for KDevelop.


Description
-------

When a project model filter is enabled, the ProjectProxyModel alters folder names to show count of items that match the filter.
Currently, these counts also include non-matched folders, because folders are not subject to filtering and the counts are calculated using rowCount(), so they are effectively pointless for tasks of evaluating how many matched files reside in some folder.

This patch makes these counts "real" by walking the model once again and counting actual files under the given folder. Unfortunately this changes complexity of model rendering to O(n^2)...


Diffs
-----

  project/projectproxymodel.h 279389b 
  project/projectproxymodel.cpp 5da4f6c 

Diff: http://git.reviewboard.kde.org/r/108210/diff/


Testing
-------

Existing unit-tests and manual testing.


Thanks,

Ivan Shapovalov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130105/53a814cb/attachment.html>


More information about the KDevelop-devel mailing list