Review Request: [3/3] Adjust kdev-ninja to EnvironmentSelectionWidget refactor.

Ivan Shapovalov intelfx100 at gmail.com
Sat Jan 5 21:22:35 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108214/
-----------------------------------------------------------

Review request for KDevelop.


Description
-------

A follow-up to https://git.reviewboard.kde.org/r/108212/ .
This removes calls to addItems() and uses "" instead of "default" as default config values.


Diffs
-----

  ninjabuilderconfig.kcfg e1d3c13 
  ninjabuilderpreferences.cpp 02aa353 

Diff: http://git.reviewboard.kde.org/r/108214/diff/


Testing
-------

Manual testing.


Thanks,

Ivan Shapovalov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130105/7e572d28/attachment.html>


More information about the KDevelop-devel mailing list