Review Request: [2/3] Adjust KDevelop to EnvironmentSelectionWidget refactor.

Ivan Shapovalov intelfx100 at gmail.com
Sat Jan 5 21:22:19 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108213/
-----------------------------------------------------------

Review request for KDevelop.


Description
-------

A follow-up to https://git.reviewboard.kde.org/r/108212/.
This removes calls to addItems() and uses "" instead of "default" as default config values.


Diffs
-----

  projectbuilders/makebuilder/makebuilderpreferences.cpp 5ffceb6 
  projectbuilders/makebuilder/makejob.cpp 378026b 
  projectmanagers/cmake/settings/cmakepreferences.cpp 2beac13 
  projectmanagers/custom-buildsystem/configwidget.cpp bcd85c5 
  projectmanagers/custom-buildsystem/custombuildsystemconfigwidget.cpp 6934c43 

Diff: http://git.reviewboard.kde.org/r/108213/diff/


Testing
-------

Manual testing.


Thanks,

Ivan Shapovalov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130105/530e95a4/attachment.html>


More information about the KDevelop-devel mailing list