Review Request 108908: Add menu action and shortcut for switch to buddy plugin

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108908/#review27835
-----------------------------------------------------------


For me, the patch looks sane. Can anyone else review?


plugins/switchtobuddy/switchtobuddyplugin.cpp
<http://git.reviewboard.kde.org/r/108908/#comment20864>

    Use i18nc(...) maybe?
    See: http://techbase.kde.org/Development/Tutorials/Localization/i18n#Adding_Context_with_i18nc.28.29


- Kevin Funk


On Feb. 11, 2013, 3:15 p.m., André Stein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108908/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2013, 3:15 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> As Milian suggested some time ago I implemented a menu action (in the Navigation menu) which allows swichting to the buddy document. A global action has been added too which allows to specify a shortcut for that action (Ctrl+Shift+s per default).
> 
> As I don't have much time right now I didn't implement Milian's idea to display a document switcher window when multiple buddies are available. Right now the plugin just switches to the first, "primary" buddy document.
> 
> 
> Diffs
> -----
> 
>   interfaces/ibuddydocumentfinder.h 05fb7ee 
>   plugins/switchtobuddy/CMakeLists.txt 795b5ed 
>   plugins/switchtobuddy/kdevswitchtobuddy.rc PRE-CREATION 
>   plugins/switchtobuddy/switchtobuddyplugin.h efa7f1e 
>   plugins/switchtobuddy/switchtobuddyplugin.cpp 2a3073a 
> 
> Diff: http://git.reviewboard.kde.org/r/108908/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Thanks,
> 
> André Stein
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130221/c1d6aba2/attachment.html>