Review Request 101028: Implement per project editor settings

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101028/#review26914
-----------------------------------------------------------


Can someone in KDevelop land give him a review? It's been open for almost 2 years

- Albert Astals Cid


On April 6, 2011, 2:47 a.m., Spencer Jackson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101028/
> -----------------------------------------------------------
> 
> (Updated April 6, 2011, 2:47 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This patch adds support for having different editor configuration settings for different projects. This works by adding a configuration option which enables an editor settings override for a specific project. When this setting is enabled, editor configuration settings will be loaded from the project configuration, rather than the kdevelop configuration. When documents are changed, the configuration will be refreshed, allowing the editor settings to change between projects.
> Note: While I was writing this, I noticed that Kate would save the configuration settings to the kdevelop configuration file during configDialog(). This was not desirable behaviour, as I couldn't prevent projects using that config from getting clobbered. Further, it broke the documented spec. I documented this in bug #270122, and have submitted a patch to Kate for review.
> 
> 
> This addresses bugs 249194 and 270122.
>     http://bugs.kde.org/show_bug.cgi?id=249194
>     http://bugs.kde.org/show_bug.cgi?id=270122
> 
> 
> Diffs
> -----
> 
>   shell/CMakeLists.txt 95641dd 
>   shell/documentcontroller.h 95b5dd7 
>   shell/documentcontroller.cpp 1b4c560 
>   shell/projectcontroller.h a2febaf 
>   shell/projectcontroller.cpp f006e24 
>   shell/projecteditorconfigurationdialog.h PRE-CREATION 
>   shell/projecteditorconfigurationdialog.cpp PRE-CREATION 
>   shell/projecteditorsettings.ui PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101028/diff/
> 
> 
> Testing
> -------
> 
> Enabled the override in kdevplatform. Opened a file from that project. Enabled a setting in the editor. Stepped into a file opened from kdevelop. Checked if setting was enabled. Enabled another setting. Stepped back into kdevplatform. Check if setting was disabled.
> 
> 
> Thanks,
> 
> Spencer Jackson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130207/00ede127/attachment-0001.html>