Review Request 106673: Fixed GPF for CMake string() commands with incorrect argument count

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106673/#review26916
-----------------------------------------------------------


This looks like it should be committed anyway to the stable branch. Even without tests?

- Kevin Funk


On Oct. 1, 2012, 4:32 p.m., Michal Malek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106673/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2012, 4:32 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> CMake project manager parser doesn't check number of arguments when it parses string() function with commands CONFIGURE, TOUPPER, TOLOWER and LENGTH. This results in GPF when for some reason too few arguments is provided for these commands. This patch adds missing checks.
> 
> 
> Diffs
> -----
> 
>   projectmanagers/cmake/parser/cmakeast.cpp bff718c618669370aad8856673ef584e60e3c314 
> 
> Diff: http://git.reviewboard.kde.org/r/106673/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michal Malek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130207/061999a0/attachment.html>