Review Request 108728: Avoid crash if there is currently no patch

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108728/#review26565
-----------------------------------------------------------

Ship it!



plugins/patchreview/patchreviewtoolview.cpp
<http://git.reviewboard.kde.org/r/108728/#comment20181>

    bool allowSelection = m_plugin->patch() && m_plugin->patch()->canSelectFiles();
    
    I would do something like that...


Looks good to me, although I never hit that crash...
Can you commit it? Send us a formatted patch otherwise!

- Aleix Pol Gonzalez


On Feb. 3, 2013, 5:10 a.m., Eli MacKenzie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108728/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2013, 5:10 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Merely toggling the Patch Review plugin off and on was sufficient
> to cause a segfault. This could be the cause of the crash in the
> cited bug report as my backtrace had the same last 22 lines.
> 
> 
> This addresses bug 306176.
>     http://bugs.kde.org/show_bug.cgi?id=306176
> 
> 
> Diffs
> -----
> 
>   plugins/patchreview/patchreviewtoolview.cpp 8239dc2a3a5c748ba46027a99aae57b6bfb0ad4f 
> 
> Diff: http://git.reviewboard.kde.org/r/108728/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eli MacKenzie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130203/97f18793/attachment.html>