Review Request 108728: Avoid crash if there is currently no patch

Eli MacKenzie argonel at gmail.com
Sun Feb 3 05:10:24 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108728/
-----------------------------------------------------------

Review request for KDevelop.


Description
-------

Merely toggling the Patch Review plugin off and on was sufficient
to cause a segfault. This could be the cause of the crash in the
cited bug report as my backtrace had the same last 22 lines.


This addresses bug 306176.
    http://bugs.kde.org/show_bug.cgi?id=306176


Diffs
-----

  plugins/patchreview/patchreviewtoolview.cpp 8239dc2a3a5c748ba46027a99aae57b6bfb0ad4f 

Diff: http://git.reviewboard.kde.org/r/108728/diff/


Testing
-------


Thanks,

Eli MacKenzie

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130203/2232dbcb/attachment.html>


More information about the KDevelop-devel mailing list