Review Request 114535: Init sessionString plasma datasource val properly

[Ivan Shapovalov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114535/#review45967
-----------------------------------------------------------

Ship it!


Sure, this is a correct change. Sorry for breaking things and not fixing them properly.

So I'd say a "Ship it", but I don't know if I (not even a bit of maintainer) may give such greenlights.

- Ivan Shapovalov


On Dec. 19, 2013, 5:19 a.m., Sergey Vidyuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114535/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2013, 5:19 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: 328952
>     http://bugs.kde.org/show_bug.cgi?id=328952
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Kdevelop sessionrc content is changed and SessionPrettyContents contains
> both seesion name and session content now. Update sessionString value
> initialization and remove outdated code in the plasma applet datasource.
> 
> 
> Diffs
> -----
> 
>   app/plasma/dataengine/kdevelopsessionsengine.h 683137a 
>   app/plasma/dataengine/kdevelopsessionsengine.cpp 284e640 
> 
> Diff: http://git.reviewboard.kde.org/r/114535/diff/
> 
> 
> Testing
> -------
> 
> Manually tested
> 
> 
> File Attachments
> ----------------
> 
> Git formatted patch
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/12/19/e0e07128-f024-4060-a663-f5fb99cba82e__0001-Init-sessionString-plasma-datasource-val-properly.patch
> 
> 
> Thanks,
> 
> Sergey Vidyuk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131220/77748fe6/attachment.html>