Review Request 114535: Init sessionString plasma datasource val properly

Sergey Vidyuk sir.vestnik at gmail.com
Thu Dec 19 05:19:51 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114535/
-----------------------------------------------------------

(Updated Dec. 19, 2013, 5:19 a.m.)


Review request for KDevelop.


Changes
-------

Wrong email in the formatted patch. Updating the file


Bugs: 328952
    http://bugs.kde.org/show_bug.cgi?id=328952


Repository: kdevelop


Description
-------

Kdevelop sessionrc content is changed and SessionPrettyContents contains
both seesion name and session content now. Update sessionString value
initialization and remove outdated code in the plasma applet datasource.


Diffs
-----

  app/plasma/dataengine/kdevelopsessionsengine.h 683137a 
  app/plasma/dataengine/kdevelopsessionsengine.cpp 284e640 

Diff: http://git.reviewboard.kde.org/r/114535/diff/


Testing
-------

Manually tested


File Attachments (updated)
----------------

Git formatted patch
  http://git.reviewboard.kde.org/media/uploaded/files/2013/12/19/e0e07128-f024-4060-a663-f5fb99cba82e__0001-Init-sessionString-plasma-datasource-val-properly.patch


Thanks,

Sergey Vidyuk

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131219/e5dd4745/attachment.html>


More information about the KDevelop-devel mailing list