Review Request 114397: Show uses for default-initialization

[Kevin Funk]

> On Dec. 17, 2013, 12:24 p.m., Milian Wolff wrote:
> > languages/cpp/cppduchain/expressionvisitor.cpp, line 1210
> > <http://git.reviewboard.kde.org/r/114397/diff/2/?file=224391#file224391line1210>
> >
> >     We could point to the semicolon :D
> >     
> >     Anyhow, without associating it with anything, can we still navigate uses in a row? I.e. will the "next use" cycle with key board shortcuts work?

Indeed, the keyboard shortcuts don't work. I was only verifying if clicking into the "Show Uses" widget works appropriately (which is working just fine).

I'd argue that the bug is in the shortcut handlers, then. Investigating a bit: ContextBrowserPlugin::switchUse uses 'allUses' from ducontext.h to collect the uses. Uses with empty ranges seem to be filtered out.

So I'm wondering: Why is the "bool noEmptyUses" parameter needed in allUses() at all? An empty range doesn't mean it is invalid. To me, it looks like allUses() should rather check whether RangeInRevision::isValid() returns true instead of checking RangeInRevision::isEmpty(). I'm proposing getting rid off the additional boolean parameter to allUses(). Hypothetically speaking here -- this is untested.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114397/#review45858
-----------------------------------------------------------


On Dec. 11, 2013, 8:12 a.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114397/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2013, 8:12 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: 300347
>     http://bugs.kde.org/show_bug.cgi?id=300347
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Show uses for default-initialization
> 
> Before this patch, declarations such as '{ A a; }' didn't increase the
> use-count of 'A::A()'
> 
> BUG: 300347
> REVIEW: 114397
> 
> 
> Diffs
> -----
> 
>   languages/cpp/cppduchain/expressionvisitor.cpp 5e1200f023ff49d9c9e341f286173ecf6ceb94a3 
>   languages/cpp/cppduchain/tests/test_duchain.cpp c7aa38de8fc7f6ff6a32d0ae24958c3ed6f30121 
> 
> Diff: http://git.reviewboard.kde.org/r/114397/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131217/612ca0a7/attachment.html>