Review Request 114397: Show uses for default-initialization

Milian Wolff mail at milianw.de
Tue Dec 17 12:24:37 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114397/#review45858
-----------------------------------------------------------

Ship it!


generally +1 from my side, I just wonder about the use navigation - maybe just keep it as-is and we can improve it later on?


languages/cpp/cppduchain/expressionvisitor.cpp
<http://git.reviewboard.kde.org/r/114397/#comment32736>

    We could point to the semicolon :D
    
    Anyhow, without associating it with anything, can we still navigate uses in a row? I.e. will the "next use" cycle with key board shortcuts work?


- Milian Wolff


On Dec. 11, 2013, 8:12 a.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114397/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2013, 8:12 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: 300347
>     http://bugs.kde.org/show_bug.cgi?id=300347
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Show uses for default-initialization
> 
> Before this patch, declarations such as '{ A a; }' didn't increase the
> use-count of 'A::A()'
> 
> BUG: 300347
> REVIEW: 114397
> 
> 
> Diffs
> -----
> 
>   languages/cpp/cppduchain/expressionvisitor.cpp 5e1200f023ff49d9c9e341f286173ecf6ceb94a3 
>   languages/cpp/cppduchain/tests/test_duchain.cpp c7aa38de8fc7f6ff6a32d0ae24958c3ed6f30121 
> 
> Diff: http://git.reviewboard.kde.org/r/114397/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131217/79e4051e/attachment.html>


More information about the KDevelop-devel mailing list