Review Request 114466: Remove noisy compiler warnings

[lycantrophe li]

> On Dec. 15, 2013, 10 p.m., Aleix Pol Gonzalez wrote:
> > languages/cpp/cppduchain/cppducontext.h, line 663
> > <http://git.reviewboard.kde.org/r/114466/diff/2/?file=225025#file225025line663>
> >
> >     this variable can go no? It never seems to be set

In terms of this: It -does- get used, although it does not show up when optimization + asserts are off.

The check is in the body of a loop which does a left-fold kind of thing, checking a range of other pointers. This part gets optimized out, so the variable gets re-assigned for every iteration, but never used.

I have in the new diff moved the assignment up so the check-and-reassigned are all grouped together.


- lycantrophe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114466/#review45735
-----------------------------------------------------------


On Dec. 16, 2013, 10:35 a.m., lycantrophe li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114466/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2013, 10:35 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: Warnings
>     http://bugs.kde.org/show_bug.cgi?id=Warnings
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Some small fixes that removes some compiler warnings.
> 
> Some warnings only appear when building for release when asserts gets defined or optimized outs, leaving variables passed to them unused. Commit 97f5869 explicitly flags some of these with Q_UNUSED silencing the warning and telling contributers that it is only there to make reading and asserting easier.
> 
> Commit 5a4f06a silences some virtual-overload compiler warnings by explicitly saying that we want the parent's visit-methods available. This is augmented by adding the override identifier to the overriden methods, which is consistent with the transition to C++11.
> 
> 
> Diffs
> -----
> 
>   projectmanagers/custom-buildsystem/custombuildsystemconfigwidget.cpp 042d523 
> 
> Diff: http://git.reviewboard.kde.org/r/114466/diff/
> 
> 
> Testing
> -------
> 
> Ran unit tests. 97f5869 does not alter any code that does work. 5a4f06a only makes explicit what used to be implicit.
> 
> 
> Thanks,
> 
> lycantrophe li
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131216/63e007f2/attachment.html>