Review Request 114466: Remove noisy compiler warnings

[lycantrophe li]

> On Dec. 15, 2013, 10 p.m., Aleix Pol Gonzalez wrote:
> > projectmanagers/custom-buildsystem/custombuildsystemconfigwidget.cpp, line 239
> > <http://git.reviewboard.kde.org/r/114466/diff/2/?file=225029#file225029line239>
> >
> >     Again, why declaring an unused variable?

Two reasons:

#1: It was there to begin with.
#2: While the variable itself is unnecessary, it gives exactly what we're checking for a name. I find it easier to read this way, especially now that the variables themselves are explicitly flagged as for-readability-not-use.

The code would be equivalent with the expression itself inside the assert.


- lycantrophe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114466/#review45735
-----------------------------------------------------------


On Dec. 15, 2013, 8:24 p.m., lycantrophe li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114466/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2013, 8:24 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: Warnings
>     http://bugs.kde.org/show_bug.cgi?id=Warnings
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Some small fixes that removes some compiler warnings.
> 
> Some warnings only appear when building for release when asserts gets defined or optimized outs, leaving variables passed to them unused. Commit 97f5869 explicitly flags some of these with Q_UNUSED silencing the warning and telling contributers that it is only there to make reading and asserting easier.
> 
> Commit 5a4f06a silences some virtual-overload compiler warnings by explicitly saying that we want the parent's visit-methods available. This is augmented by adding the override identifier to the overriden methods, which is consistent with the transition to C++11.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/cppduchain/cppducontext.h fdbe165 
>   languages/cpp/cppduchain/templatedeclaration.cpp 6b48b7a 
>   projectmanagers/cmake/cmakeutils.cpp 9aa22ca 
>   projectmanagers/cmake/tests/testhelpers.h 5cf552c 
>   projectmanagers/custom-buildsystem/custombuildsystemconfigwidget.cpp 042d523 
> 
> Diff: http://git.reviewboard.kde.org/r/114466/diff/
> 
> 
> Testing
> -------
> 
> Ran unit tests. 97f5869 does not alter any code that does work. 5a4f06a only makes explicit what used to be implicit.
> 
> 
> Thanks,
> 
> lycantrophe li
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131215/51c477ad/attachment-0001.html>