Review Request 114197: EnvironmentWidget: Always display placeholder line

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114197/#review45186
-----------------------------------------------------------



shell/settings/environmentgroupmodel.cpp
<http://git.reviewboard.kde.org/r/114197/#comment32286>

    rename to oldName (or similar) and introduce a newName for data.toString(). Also constifiy all temporaries.



shell/settings/environmentgroupmodel.cpp
<http://git.reviewboard.kde.org/r/114197/#comment32285>

    QString value = variables ( m_currentGroup ).take(var );



shell/settings/environmentgroupmodel.cpp
<http://git.reviewboard.kde.org/r/114197/#comment32288>

    newlines are wrong here



shell/settings/environmentgroupmodel.cpp
<http://git.reviewboard.kde.org/r/114197/#comment32287>

    just foreach please



util/placeholderitemproxymodel.h
<http://git.reviewboard.kde.org/r/114197/#comment32289>

    QScopedPointer please


- Milian Wolff


On Dec. 4, 2013, 10:43 p.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114197/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2013, 10:43 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> EnvironmentWidget: Always display placeholder line
> 
> Implement a custom proxy model that just adds another line at the end of
> the list. This line servers as a placeholder item. When setting data on
> that placeholder item, the EnvironmentWidget instance is notified and
> takes care of adding the actual value to the EnvironmentGroupModel
> instance.
> 
> The new PlaceholderItemProxyModel should be useful for similar widgets
> as well. For example, the BreakpointModel uses a similar approach,
> but includes the placeholder item directly in the source QAIM. => Cleanup up
> BreakPointModel and use this proxy to simplify code.
> 
> REVIEW: 114197
> 
> EnvironmentGroupModel: More API fixes
> 
> 
> Diffs
> -----
> 
>   shell/settings/environmentgroupmodel.h 5654e00121479333fea4a044f482db1622cb8851 
>   shell/settings/environmentgroupmodel.cpp 63c25020e65dcc33d517c36ca1c18176fc61272c 
>   shell/settings/environmentwidget.h 9f89ff070c0ea649bbc8c5d73a16c1b027c102bd 
>   shell/settings/environmentwidget.cpp 68d825ccf98ce9a54023107b4a889c06bd56727a 
>   shell/settings/environmentwidget.ui f9683307c0a2d61d42b04ba720be2b4f30143277 
>   util/CMakeLists.txt 87384bd70f3fa5e0696883a05a6a5efe18ebfd49 
>   util/placeholderitemproxymodel.h PRE-CREATION 
>   util/placeholderitemproxymodel.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/114197/diff/
> 
> 
> Testing
> -------
> 
> Bump
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131205/19b2a9a4/attachment-0001.html>