Review Request 114197: EnvironmentWidget: Always display placeholder line

Kevin Funk krf at
Wed Dec 4 22:43:59 UTC 2013

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 4, 2013, 10:43 p.m.)

Review request for KDevelop.


Updated change.

Repository: kdevplatform

Description (updated)

EnvironmentWidget: Always display placeholder line

Implement a custom proxy model that just adds another line at the end of
the list. This line servers as a placeholder item. When setting data on
that placeholder item, the EnvironmentWidget instance is notified and
takes care of adding the actual value to the EnvironmentGroupModel

The new PlaceholderItemProxyModel should be useful for similar widgets
as well. For example, the BreakpointModel uses a similar approach,
but includes the placeholder item directly in the source QAIM. => Cleanup up
BreakPointModel and use this proxy to simplify code.

REVIEW: 114197

EnvironmentGroupModel: More API fixes

Diffs (updated)

  shell/settings/environmentgroupmodel.h 5654e00121479333fea4a044f482db1622cb8851 
  shell/settings/environmentgroupmodel.cpp 63c25020e65dcc33d517c36ca1c18176fc61272c 
  shell/settings/environmentwidget.h 9f89ff070c0ea649bbc8c5d73a16c1b027c102bd 
  shell/settings/environmentwidget.cpp 68d825ccf98ce9a54023107b4a889c06bd56727a 
  shell/settings/environmentwidget.ui f9683307c0a2d61d42b04ba720be2b4f30143277 
  util/CMakeLists.txt 87384bd70f3fa5e0696883a05a6a5efe18ebfd49 
  util/placeholderitemproxymodel.h PRE-CREATION 
  util/placeholderitemproxymodel.cpp PRE-CREATION 





Kevin Funk

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list