Review Request 112231: Remove the area switching tabs

Aleix Pol Gonzalez aleixpol at
Mon Aug 26 01:38:27 UTC 2013

This is an automatically generated e-mail. To reply, visit:

(Updated Aug. 26, 2013, 1:38 a.m.)

Review request for KDevelop.


This change fixes:
- the cleaning up concerns by listening to areaChanged from the DebugController and the PatchReview plugin
- adds a alt+backspace shortcut to go back to code
- solves some issues raised by sven
- contains some cleaning up by milian

If nobody complains too much, I'll merge this to master tomorrow.

Aleix Pol (6):
      Switch back the AreaDisplay into a QPushButton
      The run action doesn't imply some area change
      Improve behavior of working sets on this branch
      Stop whatever we were doing on the area before leaving
      Set a default shortcut for going back to code
      Solve sven's complaints

Milian Wolff (5):
      Remove obsolete code
      Merge branch 'master' into noAreaTabs
      Cleanup code, use KDevplatform coding style.
      Use QToolButton instea do QPushButton.

l10n daemon script (1):
      SVN_SILENT made messages (.desktop file)


The area switching tabs is something that has bothered me quite a bit recently. It's something that is always visible in the screen and we barely use it. There's very little point to explicitly changing to an area, we usually do it from an action: debug, show differences, etc. These are specified by a new Area::addAction(QAction*) method.

This patch changes the current tab interface (inspired from Eclipse IIRC), for a button that tells the user what's the current area and where we can go.

The patch also removes the tabs and some unneeded abstractions in sublime/mainwindow that where only used by the tabs.

Diffs (updated)

  plugins/patchreview/patchreview.h 519c009 
  plugins/patchreview/patchreview.cpp dd54c8b 
  plugins/patchreview/patchreviewtoolview.cpp fd2799a 
  plugins/standardoutputview/standardoutputview.cpp 60379a9 
  shell/CMakeLists.txt fe5cd9b 
  shell/areadisplay.h PRE-CREATION 
  shell/areadisplay.cpp PRE-CREATION 
  shell/debugcontroller.h a8f215f 
  shell/debugcontroller.cpp cc3ae52 
  shell/mainwindow.h 2050219 
  shell/mainwindow.cpp d4f4bcb 
  shell/projectcontroller.cpp 2186d90 
  shell/runcontroller.cpp 4a5a5e4 
  shell/sessionlock.h fb5e779 
  shell/uicontroller.cpp 2c0400f 
  sublime/area.h 878c120 
  sublime/area.cpp df29ce3 
  sublime/blur.h 684ff8f 
  sublime/mainwindow.h 96b9e71 
  sublime/mainwindow.cpp f405200 
  sublime/mainwindow_p.h 7885d06 
  sublime/mainwindow_p.cpp 23c638d 
  util/projecttestjob.h 79b6f7d 
  util/projecttestjob.cpp 3d22fa5 



Been using it for a couple of days, seems safe.

File Attachments


Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list