<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112231/">http://git.reviewboard.kde.org/r/112231/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Aug. 26, 2013, 1:38 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This change fixes:
- the cleaning up concerns by listening to areaChanged from the DebugController and the PatchReview plugin
- adds a alt+backspace shortcut to go back to code
- solves some issues raised by sven
- contains some cleaning up by milian
If nobody complains too much, I'll merge this to master tomorrow.
Aleix Pol (6):
Switch back the AreaDisplay into a QPushButton
The run action doesn't imply some area change
Improve behavior of working sets on this branch
Stop whatever we were doing on the area before leaving
Set a default shortcut for going back to code
Solve sven's complaints
Milian Wolff (5):
Remove obsolete code
Merge branch 'master' into noAreaTabs
rtrim
Cleanup code, use KDevplatform coding style.
Use QToolButton instea do QPushButton.
l10n daemon script (1):
SVN_SILENT made messages (.desktop file)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The area switching tabs is something that has bothered me quite a bit recently. It's something that is always visible in the screen and we barely use it. There's very little point to explicitly changing to an area, we usually do it from an action: debug, show differences, etc. These are specified by a new Area::addAction(QAction*) method.
This patch changes the current tab interface (inspired from Eclipse IIRC), for a button that tells the user what's the current area and where we can go.
The patch also removes the tabs and some unneeded abstractions in sublime/mainwindow that where only used by the tabs.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Been using it for a couple of days, seems safe.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/patchreview/patchreview.h <span style="color: grey">(519c009)</span></li>
<li>plugins/patchreview/patchreview.cpp <span style="color: grey">(dd54c8b)</span></li>
<li>plugins/patchreview/patchreviewtoolview.cpp <span style="color: grey">(fd2799a)</span></li>
<li>plugins/standardoutputview/standardoutputview.cpp <span style="color: grey">(60379a9)</span></li>
<li>shell/CMakeLists.txt <span style="color: grey">(fe5cd9b)</span></li>
<li>shell/areadisplay.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/areadisplay.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/debugcontroller.h <span style="color: grey">(a8f215f)</span></li>
<li>shell/debugcontroller.cpp <span style="color: grey">(cc3ae52)</span></li>
<li>shell/mainwindow.h <span style="color: grey">(2050219)</span></li>
<li>shell/mainwindow.cpp <span style="color: grey">(d4f4bcb)</span></li>
<li>shell/projectcontroller.cpp <span style="color: grey">(2186d90)</span></li>
<li>shell/runcontroller.cpp <span style="color: grey">(4a5a5e4)</span></li>
<li>shell/sessionlock.h <span style="color: grey">(fb5e779)</span></li>
<li>shell/uicontroller.cpp <span style="color: grey">(2c0400f)</span></li>
<li>sublime/area.h <span style="color: grey">(878c120)</span></li>
<li>sublime/area.cpp <span style="color: grey">(df29ce3)</span></li>
<li>sublime/blur.h <span style="color: grey">(684ff8f)</span></li>
<li>sublime/mainwindow.h <span style="color: grey">(96b9e71)</span></li>
<li>sublime/mainwindow.cpp <span style="color: grey">(f405200)</span></li>
<li>sublime/mainwindow_p.h <span style="color: grey">(7885d06)</span></li>
<li>sublime/mainwindow_p.cpp <span style="color: grey">(23c638d)</span></li>
<li>util/projecttestjob.h <span style="color: grey">(79b6f7d)</span></li>
<li>util/projecttestjob.cpp <span style="color: grey">(3d22fa5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112231/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/08/23/pairs-credits2.png">pairs-credits2.png</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/08/23/pairs-credits2_1.png">pairs-credits2_1.png</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/08/23/pairs-credits2_2.png">pairs-credits2_2.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>