Review Request 112230: Show ImplementationHelpers even if header is not in same directory

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112230/#review38464
-----------------------------------------------------------

Ship it!


Ship It!

- Milian Wolff


On Aug. 23, 2013, 10:49 p.m., Max Schwarz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112230/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2013, 10:49 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> The ImplementationHelper code currently only looks for the header in the same directory. Many projects, especially libraries, have a directory layout with split include/src paths, which will result in no ImplementationHelpers being shown.
> 
> Instead allow a search in all project files by setting "fast" to false on the underlying CppUtils::sourceOrHeaderCandidate() call. The "penalty" (I doubt it is noticeable) only occurs if the header cannot be immediately found in the same directory.
> 
> 
> This addresses bug 257043.
>     http://bugs.kde.org/show_bug.cgi?id=257043
> 
> 
> Diffs
> -----
> 
>   languages/cpp/codecompletion/context.cpp 5bb5363 
> 
> Diff: http://git.reviewboard.kde.org/r/112230/diff/
> 
> 
> Testing
> -------
> 
> This patch has been in productive use for >1 month by me and a colleague. It makes coding in projects with split paths much faster and more fun!
> 
> 
> Thanks,
> 
> Max Schwarz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130824/9bf41788/attachment.html>