Review Request 112230: Show ImplementationHelpers even if header is not in same directory
Max Schwarz
max.schwarz at online.de
Fri Aug 23 22:49:16 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112230/
-----------------------------------------------------------
Review request for KDevelop.
Description
-------
The ImplementationHelper code currently only looks for the header in the same directory. Many projects, especially libraries, have a directory layout with split include/src paths, which will result in no ImplementationHelpers being shown.
Instead allow a search in all project files by setting "fast" to false on the underlying CppUtils::sourceOrHeaderCandidate() call. The "penalty" (I doubt it is noticeable) only occurs if the header cannot be immediately found in the same directory.
This addresses bug 257043.
http://bugs.kde.org/show_bug.cgi?id=257043
Diffs
-----
languages/cpp/codecompletion/context.cpp 5bb5363
Diff: http://git.reviewboard.kde.org/r/112230/diff/
Testing
-------
This patch has been in productive use for >1 month by me and a colleague. It makes coding in projects with split paths much faster and more fun!
Thanks,
Max Schwarz
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130823/5374301a/attachment-0001.html>
More information about the KDevelop-devel
mailing list