Review Request 112039: Add a CPU registers view.

[Vlas Puhov]

> On Aug. 16, 2013, 11:22 a.m., Milian Wolff wrote:
> > debuggers/gdb/registers/registercontroller.h, line 50
> > <http://git.reviewboard.kde.org/r/112039/diff/1/?file=178355#file178355line50>
> >
> >     remove these two constructors, use
> >     
> >     Register foo = { foo, value };
> >     
> >     To achieve what you want.

I don't know, IMO:
doSomething(Register (name, value));
is more readable and consumes less space than
Register r = {name, value};
doSomething( r );


> On Aug. 16, 2013, 11:22 a.m., Milian Wolff wrote:
> > debuggers/gdb/registers/registercontroller.cpp, line 96
> > <http://git.reviewboard.kde.org/r/112039/diff/1/?file=178356#file178356line96>
> >
> >     quite a lot of debug output, is that still required and useful?

Well... debug output is always useful. 
It won't be in release version anyway. And it's shown only when registers toolview is active. Ok, maybe it was a little bit too much, so I've removed some.


> On Aug. 16, 2013, 11:22 a.m., Milian Wolff wrote:
> > debuggers/gdb/registers/registercontroller.cpp, line 164
> > <http://git.reviewboard.kde.org/r/112039/diff/1/?file=178356#file178356line164>
> >
> >     foreach

I'd love to. But QT's foreach doesn't support references. Should I use c++11 foreach, or BOOST's then?


- Vlas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112039/#review37919
-----------------------------------------------------------


On Aug. 19, 2013, 9:45 p.m., Vlas Puhov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112039/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2013, 9:45 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Supported architectures: x86/x86_64, arm v7(v6 should work too).
> Features: x86/x86_64: General registers/flags, segment, FPU registers read/write. XMM - read only.
> arm: General registers/flags, VFP single - read/write, other - read only.
> 
> Related changes:
> DisassembleWidget: removed startAddress and endAddress combo boxes so as to let to resize disassemble view, but the change address functionality is still there through context menu.
> FramestackModel: if first frame doesn't contain debug information don't set currentPosition to the first frame with debug information. It allows to keep synchronization between views(gdb, editor, disassemble widget and registers) otherwise all these views'll be in different states.
> 
> 
> This addresses bug 273152.
>     http://bugs.kde.org/show_bug.cgi?id=273152
> 
> 
> Diffs
> -----
> 
>   debuggers/gdb/registers/registersview.h PRE-CREATION 
>   debuggers/gdb/registers/registersmanager.cpp PRE-CREATION 
>   debuggers/gdb/registers/registersmanager.h PRE-CREATION 
>   debuggers/gdb/registers/registercontroller_x86.cpp PRE-CREATION 
>   debuggers/gdb/registers/registercontroller_x86.h PRE-CREATION 
>   debuggers/gdb/registers/registercontroller_arm.cpp PRE-CREATION 
>   debuggers/gdb/registers/registercontroller_arm.h PRE-CREATION 
>   debuggers/gdb/registers/registercontroller.cpp PRE-CREATION 
>   debuggers/gdb/registers/registercontroller.h PRE-CREATION 
>   debuggers/gdb/disassemblewidget.cpp e1d6e8f 
>   debuggers/gdb/disassemblewidget.h 81c25fc 
>   debuggers/gdb/debuggerplugin.cpp 3533cdb 
>   debuggers/gdb/CMakeLists.txt 32ef14f 
>   debuggers/gdb/registers/registersview.cpp PRE-CREATION 
>   debuggers/gdb/registers/registersview.ui PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112039/diff/
> 
> 
> Testing
> -------
> 
> Manual only for x86/x86_64 and armv7 architectures 
> 
> 
> File Attachments
> ----------------
> 
> Related changes in kdevplatform
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/12/framestackmodel.diff
> 
> 
> Thanks,
> 
> Vlas Puhov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130819/d861feb3/attachment-0001.html>