Review Request 109986: Documents sidebar categorization by path

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109986/
-----------------------------------------------------------

(Updated April 14, 2013, 11:34 p.m.)


Review request for KDevelop.


Changes
-------

Updated the patch, all issues have been fixed. There are no visual changes, but the code is a bit cleaner now, which is quite nice. :)

This would go into master, then?


Description
-------

This patch changes the categorization in KDevelop's Documents sidebar to categorizing by path, not by mimetype anymore.

The problems with sorting by mimetypes are:

- files that are related to each other are often far away in the UI
- there are often files with the same name right underneath each other, making picking the right one almost impossible

With this patch, the sidebar is organized per path, in alphabetical order. This makes the location of a file in the UI more predictable, groups file in a more meaningful way.


I've asked a few people on IRC about this, nobody was particularly attached to the current design, so I changed the current one, instead of adding a new plugin. (It makes sense to me personally as well, I don't see how categorization by mimetype there is useful, but my use case is rather limited).

Please give it a try, tell me what you think of it. You can find the code in the sebas/sidebar branch in kdevplatform.


Diffs (updated)
-----

  plugins/documentview/kdevdocumentmodel.h 05cff45 
  plugins/documentview/kdevdocumentmodel.cpp b411a81 
  plugins/documentview/kdevdocumentview.h e237f10 
  plugins/documentview/kdevdocumentview.cpp b8c4a02 
  plugins/documentview/kdevdocumentview.desktop.cmake a89e79e 
  plugins/documentview/kdevdocumentviewdelegate.cpp b172ac0 

Diff: http://git.reviewboard.kde.org/r/109986/diff/


Testing
-------

Tested with my actual projects, behaviour feels much better, I now (kind of ;)) enjoy the sidebar, rather than outright hating it. :-)

I didn't notice any particular misbehaviour or breakage, performance also doesn't seem to be a problem.


File Attachments
----------------

original sidebar
  http://git.reviewboard.kde.org/media/uploaded/files/2013/04/12/kdevelop-sidebar-original.png
new sidebar
  http://git.reviewboard.kde.org/media/uploaded/files/2013/04/12/kdevelop-sidebar-new.png


Thanks,

Sebastian Kügler

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130414/27e0391b/attachment.html>