<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109986/">http://git.reviewboard.kde.org/r/109986/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Sebastian Kügler.</div>
<p style="color: grey;"><i>Updated April 14, 2013, 11:34 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Updated the patch, all issues have been fixed. There are no visual changes, but the code is a bit cleaner now, which is quite nice. :)
This would go into master, then?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch changes the categorization in KDevelop's Documents sidebar to categorizing by path, not by mimetype anymore.
The problems with sorting by mimetypes are:
- files that are related to each other are often far away in the UI
- there are often files with the same name right underneath each other, making picking the right one almost impossible
With this patch, the sidebar is organized per path, in alphabetical order. This makes the location of a file in the UI more predictable, groups file in a more meaningful way.
I've asked a few people on IRC about this, nobody was particularly attached to the current design, so I changed the current one, instead of adding a new plugin. (It makes sense to me personally as well, I don't see how categorization by mimetype there is useful, but my use case is rather limited).
Please give it a try, tell me what you think of it. You can find the code in the sebas/sidebar branch in kdevplatform.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with my actual projects, behaviour feels much better, I now (kind of ;)) enjoy the sidebar, rather than outright hating it. :-)
I didn't notice any particular misbehaviour or breakage, performance also doesn't seem to be a problem.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/documentview/kdevdocumentmodel.h <span style="color: grey">(05cff45)</span></li>
<li>plugins/documentview/kdevdocumentmodel.cpp <span style="color: grey">(b411a81)</span></li>
<li>plugins/documentview/kdevdocumentview.h <span style="color: grey">(e237f10)</span></li>
<li>plugins/documentview/kdevdocumentview.cpp <span style="color: grey">(b8c4a02)</span></li>
<li>plugins/documentview/kdevdocumentview.desktop.cmake <span style="color: grey">(a89e79e)</span></li>
<li>plugins/documentview/kdevdocumentviewdelegate.cpp <span style="color: grey">(b172ac0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109986/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/04/12/kdevelop-sidebar-original.png">original sidebar</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/04/12/kdevelop-sidebar-new.png">new sidebar</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>