Review Request: (code deduplication) Add class OutputExecuteJob as a common base for all output jobs which start processes

Ivan Shapovalov intelfx100 at
Thu Sep 27 16:35:10 UTC 2012

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 27, 2012, 4:35 p.m.)

Review request for KDevelop.


Using d-pointer and private class.
Any further objections/comments?


This class is going to be used instead of OutputJob as a common base for all such jobs which start processes (esp., builder jobs).

There are separate patches for make builder, cmake job and ninja builder.

Diffs (updated)

  outputview/CMakeLists.txt 3dced4c 
  outputview/outputexecutejob.h PRE-CREATION 
  outputview/outputexecutejob.cpp PRE-CREATION 



Existing unit-tests and manual testing (couple of days).


Ivan Shapovalov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list