Review Request: kdevplatform (interfaces change!): improve project KCM components selection by selecting only suitable project builders.

Ivan Shapovalov intelfx100 at gmail.com
Sat Sep 22 21:08:08 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106512/
-----------------------------------------------------------

(Updated Sept. 22, 2012, 9:08 p.m.)


Review request for KDevelop.


Changes
-------

Took Aleix's suggestion about the preferred interface because that allows for simpler implementation with CMake (no need to pass data between plugins).


Description
-------

This introduces a new function in IBuildSystemManager, called "additionalBuilderPlugins()" and returning an additional/auxiliary list of builders for that project (beyond builder() call).
That new function is used to determine a KCM list for the project, instead of statically determining it using "X-KDevelop-IRequired" and "X-KDevelop-Interfaces" properties of builder plugins.


Diffs (updated)
-----

  project/interfaces/iprojectbuilder.h 96ef0cd 
  project/interfaces/iprojectbuilder.cpp e9253a9 
  shell/projectcontroller.cpp e5fe56f 

Diff: http://git.reviewboard.kde.org/r/106512/diff/


Testing
-------

Existing unit-tests.


Thanks,

Ivan Shapovalov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120922/90ce370c/attachment.html>


More information about the KDevelop-devel mailing list