Review Request: kdevplatform (interfaces change!): improve project KCM components selection by selecting only suitable project builders.

Aleix Pol Gonzalez aleixpol at gmail.com
Sat Sep 22 18:13:36 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106512/#review19314
-----------------------------------------------------------


I guess this should be added to IProjectBuilder instead of the IProjectManager...

CMakeManager shouldn't know about if Make or Ninja is being used.

- Aleix Pol Gonzalez


On Sept. 20, 2012, 3:42 p.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106512/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2012, 3:42 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This introduces a new function in IBuildSystemManager, called "additionalBuilderPlugins()" and returning an additional/auxiliary list of builders for that project (beyond builder() call).
> That new function is used to determine a KCM list for the project, instead of statically determining it using "X-KDevelop-IRequired" and "X-KDevelop-Interfaces" properties of builder plugins.
> 
> 
> Diffs
> -----
> 
>   project/interfaces/ibuildsystemmanager.h c0813d8 
>   project/interfaces/ibuildsystemmanager.cpp 74af0e7 
>   shell/projectcontroller.cpp e5fe56f 
> 
> Diff: http://git.reviewboard.kde.org/r/106512/diff/
> 
> 
> Testing
> -------
> 
> Existing unit-tests.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120922/d33164f4/attachment.html>


More information about the KDevelop-devel mailing list