Review Request: (code deduplication) use OutputExecuteJob in MakeJob

Ivan Shapovalov intelfx100 at
Wed Sep 19 16:40:32 UTC 2012

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 19, 2012, 4:40 p.m.)

Review request for KDevelop.


Updated patch from comments and to reflect the new base class patch.

- Use IsBuilderHint property
- Pass flags to setProperties() using OR
- Use safe for loop in ::commandType()


This is related to
So, MakeJob is ported to use the class from given review.

Diffs (updated)

  projectbuilders/makebuilder/makejob.h 59d37c9 
  projectbuilders/makebuilder/makejob.cpp 9d4b85e 



Manual testing + existing unit tests.


Ivan Shapovalov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list