Review Request: (code deduplication) use OutputExecuteJob in MakeJob

[Ivan Shapovalov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106464/
-----------------------------------------------------------

(Updated Sept. 19, 2012, 4:40 p.m.)


Review request for KDevelop.


Changes
-------

Updated patch from comments and to reflect the new base class patch.

- Use IsBuilderHint property
- Pass flags to setProperties() using OR
- Use safe for loop in ::commandType()


Description
-------

This is related to https://git.reviewboard.kde.org/r/106463/.
So, MakeJob is ported to use the class from given review.


Diffs (updated)
-----

  projectbuilders/makebuilder/makejob.h 59d37c9 
  projectbuilders/makebuilder/makejob.cpp 9d4b85e 

Diff: http://git.reviewboard.kde.org/r/106464/diff/


Testing
-------

Manual testing + existing unit tests.


Thanks,

Ivan Shapovalov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120919/995bc77e/attachment.html>