Review Request: (code deduplication) Use OutputExecuteJob in CMakeJob
Ivan Shapovalov
intelfx100 at gmail.com
Mon Sep 17 09:28:14 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106465/
-----------------------------------------------------------
Review request for KDevelop.
Description
-------
This is related to https://git.reviewboard.kde.org/r/106463/.
So, CMakeJob is ported to use the class from given review.
Diffs
-----
projectbuilders/cmakebuilder/cmakejob.h 6dd0a1a
projectbuilders/cmakebuilder/cmakejob.cpp 5e4f159
projectbuilders/makebuilder/makejob.h 59d37c9
projectbuilders/makebuilder/makejob.cpp 9d4b85e
Diff: http://git.reviewboard.kde.org/r/106465/diff/
Testing
-------
Manual testing + existing unit-tests.
Thanks,
Ivan Shapovalov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120917/3629efe7/attachment.html>
More information about the KDevelop-devel
mailing list