Review Request: OpenWith - configuration dialog

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106388/#review18711
-----------------------------------------------------------


Thanks for the patch. However, it doesn't compile:
In file included from kdevplatform/plugins/openwith/openwithplugin.cpp:22:0:
kdevplatform/plugins/openwith/openwithconfig.h:30:31: fatal error: ui_openwithconfig.h: No such file or directory
compilation terminated.
Apparently the uic is not called for the UI file?


plugins/openwith/CMakeLists.txt
<http://git.reviewboard.kde.org/r/106388/#comment14815>

    what's that comment for? :)



plugins/openwith/openwithconfig.h
<http://git.reviewboard.kde.org/r/106388/#comment14819>

    I'd propose to sort those in Qt/KDE and use one consistent include style



plugins/openwith/openwithconfig.cpp
<http://git.reviewboard.kde.org/r/106388/#comment14817>

    The formatting you use here is inconsistent with what you wrote above (spaces around function calls,...); it's not very consistent across kdevelop/kdevplatform anyways, but if new code is added, it should not introduce two different formatting styles in a single file. :)



plugins/openwith/openwithconfig.cpp
<http://git.reviewboard.kde.org/r/106388/#comment14816>

    Isn't this usually done automatically by the Qt ownership system?



plugins/openwith/openwithconfig.cpp
<http://git.reviewboard.kde.org/r/106388/#comment14818>

    either remove it or remove the typo at least :)



plugins/openwith/openwithplugin.h
<http://git.reviewboard.kde.org/r/106388/#comment14820>

    remove whitespace change



plugins/openwith/openwithplugin.cpp
<http://git.reviewboard.kde.org/r/106388/#comment14821>

    remove whitespace change



plugins/openwith/openwithplugin.cpp
<http://git.reviewboard.kde.org/r/106388/#comment14822>

    why use dynamic_cast?



plugins/openwith/openwithplugin.cpp
<http://git.reviewboard.kde.org/r/106388/#comment14823>

    remove whitespace change


- Sven Brauch


On Sept. 9, 2012, 11:36 a.m., Przemek Czekaj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106388/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2012, 11:36 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Added a configuration dialog to the context menu.
> 
> 
> This addresses bug 287764.
>     http://bugs.kde.org/show_bug.cgi?id=287764
> 
> 
> Diffs
> -----
> 
>   plugins/openwith/CMakeLists.txt 8742aeb 
>   plugins/openwith/openwithconfig.h PRE-CREATION 
>   plugins/openwith/openwithconfig.cpp PRE-CREATION 
>   plugins/openwith/openwithconfig.ui PRE-CREATION 
>   plugins/openwith/openwithplugin.h 809a0e8 
>   plugins/openwith/openwithplugin.cpp 69404ef 
> 
> Diff: http://git.reviewboard.kde.org/r/106388/diff/
> 
> 
> Testing
> -------
> 
> Compiled, and local install. Tested by hand.
> 
> 
> Screenshots
> -----------
> 
> OpenWith context menu
>   http://git.reviewboard.kde.org/r/106388/s/722/
> Openwith dialog - internal option
>   http://git.reviewboard.kde.org/r/106388/s/723/
> Open with - selectable list
>   http://git.reviewboard.kde.org/r/106388/s/724/
> 
> 
> Thanks,
> 
> Przemek Czekaj
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120909/65cb1de7/attachment.html>