Review Request: Replace lockfile remove dialog code with call to existing code in kdevplatform.

Ivan Shapovalov intelfx100 at gmail.com
Wed Sep 5 09:27:11 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105918/
-----------------------------------------------------------

(Updated Sept. 5, 2012, 9:27 a.m.)


Review request for KDevelop.


Changes
-------

Update/cleanup early session locking checks.


Description
-------

Remove the lockfile remove dialog in KDevelop's main() which has been moved to kdevplatform in https://git.reviewboard.kde.org/r/105917/ .

Instead of completely removing it, replace it with an early call to the same code in kdevplatform.
This allows to do early checks without creating a splash and going to Core::initialize() when a session name is explicitly given in arguments.


Diffs (updated)
-----

  app/main.cpp 636a7a7 

Diff: http://git.reviewboard.kde.org/r/105918/diff/


Testing
-------

Existing unit-tests + manual UI testing.


Thanks,

Ivan Shapovalov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120905/651ace5e/attachment.html>


More information about the KDevelop-devel mailing list