Review Request: Cleanup of template preview
Miha Čančula
miha at noughmad.eu
Wed Oct 31 20:15:30 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107163/
-----------------------------------------------------------
Review request for KDevelop and Milian Wolff.
Description
-------
Cleans up and prettifies the template preview toolview.
- No more temporary files are used, only a single KTextEditor::Document with changing contents.
- TemplateRenderer::render() and friends no longer append error string to its output. Instead, errors are reported by a separate method.
- In the template preview, these errors are reported in a KMessageWidget at the top.
- Notifications that the current document is not a template is displayed in the same message widget, as information.
Diffs
-----
language/codegen/templaterenderer.h ab904237a19b10942e73e24d7ece58a9b9a2e27f
language/codegen/templaterenderer.cpp 9cc9574ccc741fa32a67bd38f85c962e43f2cbba
plugins/filetemplates/templatepreview.h 2c85660d3451869881cc1883f9e7e78968b9fad2
plugins/filetemplates/templatepreview.cpp a3fa44a57fe07c3adce437a86b6e03aeeeecb046
plugins/filetemplates/templatepreview.ui 7ee0b11886d62c622c908497a763bcb6dbf544e2
Diff: http://git.reviewboard.kde.org/r/107163/diff/
Testing
-------
Tested locally with a handful of template and non-template files.
Screenshots
-----------
Preview of a correct template
http://git.reviewboard.kde.org/r/107163/s/806/
Error reporting
http://git.reviewboard.kde.org/r/107163/s/807/
Thanks,
Miha Čančula
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121031/76852eba/attachment.html>
More information about the KDevelop-devel
mailing list