<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107163/">http://git.reviewboard.kde.org/r/107163/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Milian Wolff.</div>
<div>By Miha Čančula.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Cleans up and prettifies the template preview toolview.
- No more temporary files are used, only a single KTextEditor::Document with changing contents.
- TemplateRenderer::render() and friends no longer append error string to its output. Instead, errors are reported by a separate method.
- In the template preview, these errors are reported in a KMessageWidget at the top.
- Notifications that the current document is not a template is displayed in the same message widget, as information. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested locally with a handful of template and non-template files. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>language/codegen/templaterenderer.h <span style="color: grey">(ab904237a19b10942e73e24d7ece58a9b9a2e27f)</span></li>
<li>language/codegen/templaterenderer.cpp <span style="color: grey">(9cc9574ccc741fa32a67bd38f85c962e43f2cbba)</span></li>
<li>plugins/filetemplates/templatepreview.h <span style="color: grey">(2c85660d3451869881cc1883f9e7e78968b9fad2)</span></li>
<li>plugins/filetemplates/templatepreview.cpp <span style="color: grey">(a3fa44a57fe07c3adce437a86b6e03aeeeecb046)</span></li>
<li>plugins/filetemplates/templatepreview.ui <span style="color: grey">(7ee0b11886d62c622c908497a763bcb6dbf544e2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107163/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107163/s/806/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/31/kdevelop-template-preview-1_400x100.png" style="border: 1px black solid;" alt="Preview of a correct template" /></a>
<a href="http://git.reviewboard.kde.org/r/107163/s/807/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/31/kdevelop-template-preview-2_400x100.png" style="border: 1px black solid;" alt="Error reporting" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>