Review Request: Make StandardOutputView Work as Advertised on IOutputView

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107126/#review21192
-----------------------------------------------------------


I'll whip up something on my own, I think more changes are required to fix this properly - sorry for the mess. this time, I'll add a proper unit test also

- Milian Wolff


On Oct. 30, 2012, 8:42 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107126/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2012, 8:42 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> From IOutputView's documentation of the registerToolView method: "If there already exists a toolview with this title and type return the existing id"
> 
> 
> Diffs
> -----
> 
>   plugins/standardoutputview/standardoutputview.cpp 1a4cf8b 
> 
> Diff: http://git.reviewboard.kde.org/r/107126/diff/
> 
> 
> Testing
> -------
> 
> I'm writing a plugin that does not use a standard output view, and was crashing after using it twice without this patch. It is working more or less ok now (the crash is fixed, but there is an unrelated error elsewhere).
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121031/766895f2/attachment.html>