Review Request: Make StandardOutputView Work as Advertised on IOutputView

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107126/#review21146
-----------------------------------------------------------


The change was done more or less intentionally so this should wait for Milian's review since he was the one to change the logic. I'm not sure why though, the commit itself does not make that much sense.

- Andreas Pakulat


On Oct. 30, 2012, 8:42 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107126/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2012, 8:42 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> From IOutputView's documentation of the registerToolView method: "If there already exists a toolview with this title and type return the existing id"
> 
> 
> Diffs
> -----
> 
>   plugins/standardoutputview/standardoutputview.cpp 1a4cf8b 
> 
> Diff: http://git.reviewboard.kde.org/r/107126/diff/
> 
> 
> Testing
> -------
> 
> I'm writing a plugin that does not use a standard output view, and was crashing after using it twice without this patch. It is working more or less ok now (the crash is fixed, but there is an unrelated error elsewhere).
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121030/6f01b18f/attachment.html>