Issues parsing buildoutput

[Morten Volden]

fredag den 26. oktober 2012 skrev Morten Volden :

> onsdag den 24. oktober 2012 skrev Peter M. Clausen :
>
> Ok, i understand. I will try to figure out how to commit. Any hints for a
> newbie?
>
>
> The code will need to pass review first.  Once it has passed you may be
> able to get someone to submit it for you. I do, however, reccomed that you
> take the time to create an account.
>
> The multiple line issue I don't quite know how to solve. Anyone got a
> suggestion or example for multi-line regex with qstring?
>
> /Peter
>
>
> I May have a suggestion for an approach. Will try to post it once i get my
> hands on something more suitable for writing mails than my phone.
>
> Since you only have one line each time errorInLine is called you need to
> store the information that is available in the first line. This could for
> example be by using an action item in a similar way it is used when cmake
> writes out 'cd /x/y/z.cpp'.
>
> Hope this helps
>
> Morten
>
>
> Am 23.10.2012 22:32 schrieb "Morten Volden" <mvolden2 at gmail.com>:
> >
> >
> >
> > 2012/10/16 Peter M. Clausen <petermichaelclausen at gmail.com>
> >>
> >> Hi Morten,
> >>
> >> I will not be hacking much in KDE - I'm a fortran guy, not C++ :-)) So
> before I add an account and all I would ask if you perhaps would to look at
> the (fairly trivial) changes I made? And if they are OK push them into the
> master branch. I'm new to git as well, so I dont really get it regarding
> pushing changes...
> >>
> > Any change that I propose will still need to be reviewed by the core
> developers. In theory I could still do that, but I sincerely believe that
> both you and KDevelop is best helped if you do.
> >
> >>
> >> I believe that the files attached are OK ('modified_files.tar.gz') - if
> you want the diff it is in 'diff_origin_master.txt'. I've modified the
> tests as well, and they run without errors.
> >>
> >> One thing I dont understand is that it does NOT work for gfortran in
> kdevelop! (see Screenshot_kdev.png). It does not highlight and I cant jump
> in code. If you install gfortran it should be strainght forward to open the
> Cmake-mini-test_f (in 'test_f.tar.gz') I've made.
> >>
> > I have not had the time to try out your patch on my machine, but I think
> I may have an idea of why the unit test passes and it fails when you
> compile. The gfortranError2 test you have written: You are feeding the
> errorInLine function multiple lines, but when you compile it will receive
> each line separately, and therefore the regex will not match.
> >
> >
> > Regards
> >
> > Morten
> >
> >>
> >> It is only gfortran thats a problem - intel fortran works like a charm
> with highlighting as well as jumping to the correct places in the code.
> >>
> >> Thanks for your help!
> >>
> >> Best regards
> >>
> >> Peter
> >>
> >>
> >>
> >>
> >> 2012/10/15 Morten Volden <mvolden2 at gmail.com>
> >>>
> >>> Hi Peter
> >>>
> >>> As far as I know the re-factoring of the output filtering is not in
> the 4.4. branch, so when you say 4.4. branch I assume you mean master.
> >>>
> >>> The ErrorFormat class constructors looks like this:
> >>>
> >>> ErrorFormat( const QString& regExp, int file, int line, int text, int
> column=-1 );
> >>>
> >>> ErrorFormat( const QString& regExp, int file, int line, int text,
> const QString& comp, int column=-1 );
> >>>
> >>> The 'file', 'line', 'text', and 'column' integers indicate what group
> in the regExp that information is found (for example the file information
> is found in the second pair of parentheses in the regular expression in the
> ErrorFormat constructor below.)
> >>>
> >>> I am not near my workstation right now so I cannot say for certain,
> but something like the ErrorFormat constructor below should work (In
> master).
> >>>
> >>> ErrorFormat( "^fortcom: ([a-zA-Z]+): (.*), line ([0-9]+):(.*)", 2, 3,
> 1, "intel" )
> >>>
> >>> In the outputview/test directory there is a file called
> filteringstrategytest.cpp. I highly recommend that you implement a unittest
> for your case there.
> >>>
> >>> Once you have a working patch and test in place, you can use kdevelop
> to post that on git.reviewboard.kde.org
> >>>
> >>> Hope this helps
> >>>
> >>> /Morten
> >>>
> >>> 2012/10/15 Peter M. Clausen <petermichaelclausen at gmail.com>
> >>>>
> >>>> sorry - I used the wrong list...
> >>>>
> >>>>
> >>>> ---------- Forwarded message ----------
> >>>> From: Peter M. Clausen <
>






-- 
- When the split is pulled, mr. Grenade is no longer our friend
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121028/e58e4803/attachment.html>