Review Request: Use TestCore in cmakecompliance test to cleanup sessions properly

Aleix Pol Gonzalez aleixpol at gmail.com
Fri Oct 19 17:38:01 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106953/#review20578
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Oct. 19, 2012, 5:33 p.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106953/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2012, 5:33 p.m.)
> 
> 
> Review request for KDevelop and Aleix Pol Gonzalez.
> 
> 
> Description
> -------
> 
> Default core doesn't actually clean up sessions even when shut down properly (they are created without "temporary" flag).
> Didn't notice this in https://git.reviewboard.kde.org/r/106851/, so this one may be considered a fixup.
> 
> 
> Diffs
> -----
> 
>   projectmanagers/cmake/tests/cmakecompliance.cpp 8dd503d 
> 
> Diff: http://git.reviewboard.kde.org/r/106953/diff/
> 
> 
> Testing
> -------
> 
> The changed unit-test works properly; actually, are there any caveats in using TestCore instead of just Core?
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121019/b44f00db/attachment.html>


More information about the KDevelop-devel mailing list