Review Request: Use TestCore in cmakecompliance test to cleanup sessions properly

Ivan Shapovalov intelfx100 at gmail.com
Fri Oct 19 17:33:11 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106953/
-----------------------------------------------------------

Review request for KDevelop and Aleix Pol Gonzalez.


Description
-------

Default core doesn't actually clean up sessions even when shut down properly (they are created without "temporary" flag).
Didn't notice this in https://git.reviewboard.kde.org/r/106851/, so this one may be considered a fixup.


Diffs
-----

  projectmanagers/cmake/tests/cmakecompliance.cpp 8dd503d 

Diff: http://git.reviewboard.kde.org/r/106953/diff/


Testing
-------

The changed unit-test works properly; actually, are there any caveats in using TestCore instead of just Core?


Thanks,

Ivan Shapovalov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121019/ef1ba099/attachment.html>


More information about the KDevelop-devel mailing list