Review Request: Prevent code navigation tooltip hiding when moving mouse over the identifier.

Maciej Cencora m.cencora at gmail.com
Fri Oct 19 09:07:44 UTC 2012



> On Aug. 18, 2012, 4:20 p.m., David Nolden wrote:
> > language/duchain/duchainutils.h, line 69
> > <http://git.reviewboard.kde.org/r/105403/diff/1/?file=70903#file70903line69>
> >
> >     Since the DUChain is used, and the function doesn't do any internal locking, the duchain _must_ be locked when this is called.

Fixed the comment. I don't really know the DUChain that well, so I copied what is stated for function above since it also uses DUChain in similar way.


- Maciej


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105403/#review17667
-----------------------------------------------------------


On Oct. 19, 2012, 9:03 a.m., Maciej Cencora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105403/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2012, 9:03 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This works by looking up the item's Range in DUChain and adding its geometry boundaries as extra rectangle to tooltop.
> 
> If there's another way to get line height (in pixels) in kate I'd be more than happy to use it instead of the hack I wrote.
> 
> 
> Diffs
> -----
> 
>   language/duchain/duchainutils.h de6b5f9 
>   language/duchain/duchainutils.cpp 345aa3c 
>   plugins/contextbrowser/contextbrowser.cpp 4587657 
> 
> Diff: http://git.reviewboard.kde.org/r/105403/diff/
> 
> 
> Testing
> -------
> 
> Manual testing performed
> 
> 
> Thanks,
> 
> Maciej Cencora
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121019/929d5bd4/attachment.html>


More information about the KDevelop-devel mailing list