Review Request: Prevent code navigation tooltip hiding when moving mouse over the identifier.

[Maciej Cencora]

> On July 16, 2012, 8:22 p.m., Milian Wolff wrote:
> >
> 
> Milian Wolff wrote:
>     Ping, are you going to work on this? Otherwise I'll try to bring this patch into master.

I'm really sorry, for such a late response. I totally forgot about this.


> On July 16, 2012, 8:22 p.m., Milian Wolff wrote:
> > language/duchain/duchainutils.cpp, line 340
> > <http://git.reviewboard.kde.org/r/105403/diff/1/?file=70904#file70904line340>
> >
> >     this looks wrong, please reuse the declarationUnderCursor function available in the same file and just return it's range.
> >     
> >     if that fails, please look at the context browser plugin, it should have some code to find that range and reuse that code (by pushing it here).

Fixed by using declarationUnderCursor as suggested.


> On July 16, 2012, 8:22 p.m., Milian Wolff wrote:
> > plugins/contextbrowser/contextbrowser.cpp, line 384
> > <http://git.reviewboard.kde.org/r/105403/diff/1/?file=70905#file70905line384>
> >
> >     patches for ktexteditor would be welcome, and: what happens for 1-line documents (does it just fail or is it crashing or so?)
> >     
> >     if it just fails, this is OK for me as these docs should occur fairly rarely

Sorry, I won't probably provide patches for ktexteditor.

I've checked the 1-liner and it works just fine.


- Maciej


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105403/#review15983
-----------------------------------------------------------


On Oct. 19, 2012, 9:03 a.m., Maciej Cencora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105403/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2012, 9:03 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This works by looking up the item's Range in DUChain and adding its geometry boundaries as extra rectangle to tooltop.
> 
> If there's another way to get line height (in pixels) in kate I'd be more than happy to use it instead of the hack I wrote.
> 
> 
> Diffs
> -----
> 
>   language/duchain/duchainutils.h de6b5f9 
>   language/duchain/duchainutils.cpp 345aa3c 
>   plugins/contextbrowser/contextbrowser.cpp 4587657 
> 
> Diff: http://git.reviewboard.kde.org/r/105403/diff/
> 
> 
> Testing
> -------
> 
> Manual testing performed
> 
> 
> Thanks,
> 
> Maciej Cencora
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121019/81bf210d/attachment.html>