Review Request: OpenWith - configuration dialog

[Aleix Pol Gonzalez]

> On Oct. 16, 2012, 9:09 p.m., Przemek Czekaj wrote:
> > plugins/openwith/openwithconfig.ui, line 25
> > <http://git.reviewboard.kde.org/r/106388/diff/1/?file=84307#file84307line25>
> >
> >     Embedded editor plugin? This may create an misunderstood for end user. Option open internal will always open file inside kdevelop

Maybe change to "Open in KDevelop"?


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106388/#review20471
-----------------------------------------------------------


On Sept. 10, 2012, 7:40 a.m., Przemek Czekaj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106388/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2012, 7:40 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Added a configuration dialog to the context menu.
> 
> @edit
> give me few days, I will improve patch.
> 
> 
> This addresses bug 287764.
>     http://bugs.kde.org/show_bug.cgi?id=287764
> 
> 
> Diffs
> -----
> 
>   plugins/openwith/CMakeLists.txt 8742aeb 
>   plugins/openwith/openwithconfig.h PRE-CREATION 
>   plugins/openwith/openwithconfig.cpp PRE-CREATION 
>   plugins/openwith/openwithconfig.ui PRE-CREATION 
>   plugins/openwith/openwithplugin.h 809a0e8 
>   plugins/openwith/openwithplugin.cpp 69404ef 
> 
> Diff: http://git.reviewboard.kde.org/r/106388/diff/
> 
> 
> Testing
> -------
> 
> Compiled, and local install. Tested by hand.
> 
> 
> Screenshots
> -----------
> 
> OpenWith context menu
>   http://git.reviewboard.kde.org/r/106388/s/722/
> Openwith dialog - internal option
>   http://git.reviewboard.kde.org/r/106388/s/723/
> Open with - selectable list
>   http://git.reviewboard.kde.org/r/106388/s/724/
> 
> 
> Thanks,
> 
> Przemek Czekaj
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121017/c4dad6b6/attachment.html>