<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106388/">http://git.reviewboard.kde.org/r/106388/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 16th, 2012, 9:09 p.m., <b>Przemek Czekaj</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106388/diff/1/?file=84307#file84307line25" style="color: black; font-weight: bold; text-decoration: underline;">plugins/openwith/openwithconfig.ui</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">25</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <string>Open internal</string></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Embedded editor plugin? This may create an misunderstood for end user. Option open internal will always open file inside kdevelop</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Maybe change to "Open in KDevelop"?</pre>
<br />
<p>- Aleix</p>
<br />
<p>On September 10th, 2012, 7:40 a.m., Przemek Czekaj wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Przemek Czekaj.</div>
<p style="color: grey;"><i>Updated Sept. 10, 2012, 7:40 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added a configuration dialog to the context menu.
@edit
give me few days, I will improve patch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled, and local install. Tested by hand.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=287764">287764</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/openwith/CMakeLists.txt <span style="color: grey">(8742aeb)</span></li>
<li>plugins/openwith/openwithconfig.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/openwith/openwithconfig.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/openwith/openwithconfig.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/openwith/openwithplugin.h <span style="color: grey">(809a0e8)</span></li>
<li>plugins/openwith/openwithplugin.cpp <span style="color: grey">(69404ef)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106388/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106388/s/722/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/09/09/kdevplatform-openwith1_400x100.png" style="border: 1px black solid;" alt="OpenWith context menu" /></a>
<a href="http://git.reviewboard.kde.org/r/106388/s/723/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/09/09/kdevplatform-openwith2_400x100.png" style="border: 1px black solid;" alt="Openwith dialog - internal option" /></a>
<a href="http://git.reviewboard.kde.org/r/106388/s/724/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/09/09/kdevplatform-openwith3_400x100.png" style="border: 1px black solid;" alt="Open with - selectable list" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>