Review Request: Correctly enable/disable the "Get" button from the "Fetch Project" dialog for Project Providers.

[Miquel Sabaté]

> On Oct. 15, 2012, 9:53 p.m., Aleix Pol Gonzalez wrote:
> > interfaces/iprojectprovider.h, line 23
> > <http://git.reviewboard.kde.org/r/106904/diff/1/?file=90743#file90743line23>
> >
> >     empty change?

Merely aesthetic. To keep the "#define IPROJECTPROVIDER_H" and the "include's section" separated. Just something I use to do :)


- Miquel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106904/#review20437
-----------------------------------------------------------


On Oct. 15, 2012, 9:13 p.m., Miquel Sabaté wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106904/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2012, 9:13 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Added an isCorrect() method to the IProjectProvider interface, exactly as in the VcsLocationWidget class. This method will then be used in the reevaluateCorrection() method inside the ProjectSourcePage class to check whether the "Get" button should be enabled or not.
> 
> 
> Diffs
> -----
> 
>   interfaces/iprojectprovider.h 6548335 
>   shell/projectsourcepage.cpp 7707ad1 
> 
> Diff: http://git.reviewboard.kde.org/r/106904/diff/
> 
> 
> Testing
> -------
> 
> Tested with the KDE Project Provider.
> 
> 
> Thanks,
> 
> Miquel Sabaté
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121015/af3e9ea5/attachment.html>