Review Request: Correctly enable/disable the "Get" button from the "Fetch Project" dialog for Project Providers.

Aleix Pol Gonzalez aleixpol at gmail.com
Mon Oct 15 21:53:06 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106904/#review20437
-----------------------------------------------------------



interfaces/iprojectprovider.h
<http://git.reviewboard.kde.org/r/106904/#comment16135>

    empty change?


- Aleix Pol Gonzalez


On Oct. 15, 2012, 9:13 p.m., Miquel Sabaté wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106904/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2012, 9:13 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Added an isCorrect() method to the IProjectProvider interface, exactly as in the VcsLocationWidget class. This method will then be used in the reevaluateCorrection() method inside the ProjectSourcePage class to check whether the "Get" button should be enabled or not.
> 
> 
> Diffs
> -----
> 
>   interfaces/iprojectprovider.h 6548335 
>   shell/projectsourcepage.cpp 7707ad1 
> 
> Diff: http://git.reviewboard.kde.org/r/106904/diff/
> 
> 
> Testing
> -------
> 
> Tested with the KDE Project Provider.
> 
> 
> Thanks,
> 
> Miquel Sabaté
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121015/c21dcbd8/attachment.html>


More information about the KDevelop-devel mailing list