Review Request: Properly handle deletion of stale sessions (using their lock status).
Commit Hook
null at kde.org
Mon Oct 15 13:08:22 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106802/#review20376
-----------------------------------------------------------
This review has been submitted with commit 7d0b2cb35078e2c9bb18e5206b034302421ed286 by Ivan Shapovalov to branch master.
- Commit Hook
On Oct. 12, 2012, 7:25 p.m., Ivan Shapovalov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106802/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2012, 7:25 p.m.)
>
>
> Review request for KDevelop.
>
>
> Description
> -------
>
> In one of the places (empty session cleanup), uncomment session deletion and use tryLockSession() to determine whether it is actually possible.
> In another one (session chooser dialog), wrap the existing session deletion into a tryLockSession() conditional.
>
>
> Diffs
> -----
>
> shell/sessioncontroller.cpp c9fac67
>
> Diff: http://git.reviewboard.kde.org/r/106802/diff/
>
>
> Testing
> -------
>
> Made sure that the sessions are cleaned correctly.
>
>
> Thanks,
>
> Ivan Shapovalov
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121015/5c5a3145/attachment.html>
More information about the KDevelop-devel
mailing list