Review Request: Properly handle deletion of stale sessions (using their lock status).

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106802/#review20281
-----------------------------------------------------------

Ship it!


is it also working properly for unit test runs? i.e. are the temp sessions removed there? if so, please go ahead and commit.

thanks

- Milian Wolff


On Oct. 12, 2012, 7:25 p.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106802/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2012, 7:25 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> In one of the places (empty session cleanup), uncomment session deletion and use tryLockSession() to determine whether it is actually possible.
> In another one (session chooser dialog), wrap the existing session deletion into a tryLockSession() conditional.
> 
> 
> Diffs
> -----
> 
>   shell/sessioncontroller.cpp c9fac67 
> 
> Diff: http://git.reviewboard.kde.org/r/106802/diff/
> 
> 
> Testing
> -------
> 
> Made sure that the sessions are cleaned correctly.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121013/4ef3314a/attachment.html>