Review Request: Replace lockfile remove dialog code with call to existing code in kdevplatform.

Milian Wolff mail at milianw.de
Thu Oct 11 15:40:54 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105918/#review20197
-----------------------------------------------------------

Ship it!


Ship It!

- Milian Wolff


On Sept. 5, 2012, 9:27 a.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105918/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2012, 9:27 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Remove the lockfile remove dialog in KDevelop's main() which has been moved to kdevplatform in https://git.reviewboard.kde.org/r/105917/ .
> 
> Instead of completely removing it, replace it with an early call to the same code in kdevplatform.
> This allows to do early checks without creating a splash and going to Core::initialize() when a session name is explicitly given in arguments.
> 
> 
> Diffs
> -----
> 
>   app/main.cpp 636a7a7 
> 
> Diff: http://git.reviewboard.kde.org/r/105918/diff/
> 
> 
> Testing
> -------
> 
> Existing unit-tests + manual UI testing.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121011/c98bac2d/attachment.html>


More information about the KDevelop-devel mailing list