ProjectModel broken since 91da12250193e51197c982d57984228e29b27870

[Aleix Pol]

On Thu, Oct 11, 2012 at 3:47 PM, Milian Wolff <mail at milianw.de> wrote:
> Hey David / All.
>
> I just stumbled upon rev 91da12250 and notice that it is severly abusing the
> Qt model/view system. Just running the unit tests shows this (asserts in
> ModelTest).
>
> Generally, this commit renders the ProjectModel unusable when used without the
> ProjectProxyModel. While the functionality is certainly cool, I must say that
> it is very unfortunate that I didn't review this sooner... The test was
> failing for quite some time now...
>
> Anyhow, what must be done (question is, whether it *can* be done properly):
>
> - revert all related changes in projectmodel.cpp
> - move functionality completely over to the ProjectProxyModel, probably
> requires overloads of rowCount, mapFromSource, mapToSource as well as proper
> signal emission whenever the filter changes and the "show/hide X filtered
> items..." row gets added/removed from a folder.
>
> This should be fixed. I think we could ask for help from e.g. Stephen Kelly if
> we want to know how this should be implemented properly.
>
> Cheers
> --
> Milian Wolff
> mail at milianw.de
> http://milianw.de
> --
> KDevelop-devel mailing list
> KDevelop-devel at kdevelop.org
> https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
>

Well, maybe David can look into moving it back to the proxy?

These things make me realize that pre-commit review would be useful... :/

Aleix